Skip to content

Always return outermost thread id #6465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always return outermost thread id #6465

wants to merge 1 commit into from
+558 −408

Conversation

@Pansysk75
Copy link
Member

@Pansysk75 Pansysk75 commented Mar 28, 2024

// Re-opening of PR #6413 authored by @hkaiser

-flyby: deprecate get_outer_self_id
-flyby: ignoring locks during termination detection

@Pansysk75 Pansysk75 requested a review from hkaiser as a code owner March 28, 2024 21:14
@codacy-production
Copy link

codacy-production bot commented Mar 28, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ -0.66% ✅ 91.29%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b60bcf2) 243597 208937 85.77%
Head commit (0deeb72) 193827 (-49770) 164963 (-43974) 85.11% (-0.66%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6465) 241 220 91.29%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@hkaiser hkaiser force-pushed the fixing_6333_2 branch 2 times, most recently from 12fc4f3 to b05a03e Compare April 28, 2024 17:13
@StellarBot
Copy link

StellarBot commented Apr 28, 2024

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)-(=)

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-04-28T17:13:48+00:00
HPX Commitd27ac2e5e4df47
Datetime2024-03-18T09:18:04.949759-05:002024-04-28T18:18:24.491797-05:00
Envfile
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-04-28T17:13:48+00:00
HPX Commitd27ac2e5e4df47
Datetime2024-03-18T09:19:53.062988-05:002024-04-28T18:20:12.047427-05:00
Envfile
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add=(=)=
Stream Benchmark - Scale(=)(=)(=)
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy=(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2024-03-18T14:00:30+00:002024-04-28T17:13:48+00:00
HPX Commitd27ac2e5e4df47
Datetime2024-03-18T09:20:13.002391-05:002024-04-28T18:20:28.690059-05:00
Envfile
Clusternamerostamrostam
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Compiler/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1/opt/apps/llvm/13.0.1/bin/clang++ 13.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser hkaiser added this to the 1.11.0 milestone May 7, 2024
@Pansysk75
Copy link
Member Author

Pansysk75 commented May 26, 2024

retest lsu

@hkaiser hkaiser force-pushed the fixing_6333_2 branch 2 times, most recently from f2e886f to 3b8f26c Compare May 10, 2025 18:00
@hkaiser
Always return outermost thread id
0deeb72 
-flyby: deprecate get_outer_self_id
-flyby: ignoring locks during termination detection

Signed-off-by: Hartmut Kaiser <[email protected]>
@StellarBot
Copy link

StellarBot commented May 10, 2025

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:00:08+00:00
HPX Commitaf29eae938ae94
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Datetime2025-01-27T09:56:10.969382-06:002025-05-10T13:05:16.413047-05:00

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:00:08+00:00
HPX Commitaf29eae938ae94
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Datetime2025-01-27T09:58:01.174130-06:002025-05-10T13:07:09.346562-05:00

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add=(=)(=)
Stream Benchmark - Scale(=)(=)=
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:00:08+00:00
HPX Commitaf29eae938ae94
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu
Envfile
Clusternamerostamrostam
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Datetime2025-01-27T09:58:21.725422-06:002025-05-10T13:07:30.428981-05:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@StellarBot
Copy link

StellarBot commented May 10, 2025

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Commitaf29eae090dbb7
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:03:59+00:00
Envfile
Clusternamerostamrostam
Datetime2025-01-27T09:56:10.969382-06:002025-05-10T13:11:02.937333-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch(=)

Info

PropertyBeforeAfter
HPX Commitaf29eae090dbb7
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:03:59+00:00
Envfile
Clusternamerostamrostam
Datetime2025-01-27T09:58:01.174130-06:002025-05-10T13:12:53.455236-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)=
Stream Benchmark - Scale(=)-=
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)(=)=

Info

PropertyBeforeAfter
HPX Commitaf29eae090dbb7
HPX Datetime2025-01-27T15:49:39+00:002025-05-10T18:03:59+00:00
Envfile
Clusternamerostamrostam
Datetime2025-01-27T09:58:21.725422-06:002025-05-10T13:13:13.793461-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser
Copy link
Member

hkaiser commented May 11, 2025

retest lsu

@StellarBot
Copy link

StellarBot commented May 11, 2025

Performance test report

HPX Performance

Comparison

BENCHMARKFORK_JOIN_EXECUTORPARALLEL_EXECUTORSCHEDULER_EXECUTOR
For Each(=)(=)(=)

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-11T15:18:28+00:00
HPX Commitaf29eae94108b4
Clusternamerostamrostam
Datetime2025-01-27T09:56:10.969382-06:002025-05-11T12:43:03.034258-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-11T15:18:28+00:00
HPX Commitaf29eae94108b4
Clusternamerostamrostam
Datetime2025-01-27T09:58:01.174130-06:002025-05-11T12:44:55.116718-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Comparison

BENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATOR
Stream Benchmark - Add(=)(=)(=)
Stream Benchmark - Scale(=)(=)+
Stream Benchmark - Triad(=)(=)(=)
Stream Benchmark - Copy(=)==

Info

PropertyBeforeAfter
HPX Datetime2025-01-27T15:49:39+00:002025-05-11T15:18:28+00:00
HPX Commitaf29eae94108b4
Clusternamerostamrostam
Datetime2025-01-27T09:58:21.725422-06:002025-05-11T12:45:15.561808-05:00
Compiler/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8/opt/apps/llvm/18.1.8/bin/clang++ 18.1.8
Envfile
Hostnamemedusa08.rostam.cct.lsu.edumedusa08.rostam.cct.lsu.edu

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (≤5%)
++/--Large performance improvement/degradation (≤10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@hkaiser
Copy link
Member

hkaiser commented May 15, 2025

This looks surprisingly good, let's merge it. @Pansysk75 ?

@hkaiser hkaiser modified the milestones: 1.11.0, 2.0.0 Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hkaiser hkaiser Awaiting requested review from hkaiser hkaiser is a code owner

Assignees

No one assigned

Labels

category: threadmanager type: compatibility issue type: enhancement

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Pansysk75 @StellarBot @hkaiser